@microsoft-github-policy-service agree company="Pixelgen Technologies AB"

Single comment for review left inline, if 3.12 does break it then let's not worry about it now we'll just create an issue to fix it for later :)

Seems like it is failing right now because maturin's cli args changed since the time I wrote it (which is why I had it pinned to the [0.12..0.13) range, I was tired of breaking changes. Once that is fixed in the github action for building it, we should be good to go though.

https://github.com/johandahlberg/graspologic-native/blob/packaging-fixes/.github/workflows/build.yml#L76

You will also need to bump the version in pyo3's Cargo.toml file to at least 1.2.1 (we can't publish over old versions and the build is set to fail if any of the publication steps fails). I don't think it's really worth trying to make Cargo happy with the pep rules around "1.2.0.post1" as a valid version, and we're not changing anything in the api so 1.2.1 should comply enough with semver to make everyone as happy as they're going to get :)

Thank you for the review!

I can't seem to find the inline comment you mention.

For the other issues I have:

• changed the build actions to use PyO3/maturin-action@v1 which as far as I've been able to tell is the new version of that used to be messense/maturin-action@v1. And then used that to set the target for the MacOS build.
• explicitly adding build the source dist for the ubuntu build, since otherwise it didn't appear to show up
• updated the version to 1.2.1 as suggested
• locked the maturin version to be [1.4, 2.0), with 1.4.0 specifically being used in the github workflow
• updated a bunch of "base" actions to their latest versions to quite the warnings associated with them

Let me know if there is anything I've missed, or that you'd like done differently. Also, feel free to push any changes you deem necessary to this branch.

My inline comments have fully disappeared. Let me do this again and check. In the meantime I'm going to approve the workflow and make sure it's working e2e.

Edit: sorry about sending you on a wild goose chase re: the inline comments. I don't know what happened! I hope you didn't spend too much time searching for them 😬

Thank you for finishing this up! And, no worries about the inline comment - I didn't spend long looking for it.

Thank you!